feat(tasks): Consolidate schedule management into task_schedules

- Add schedule CRUD endpoints to /api/tasks/schedules - Add Schedules section to TasksDashboard with edit/delete/bulk actions - Deprecate job_schedules table (entries disabled in DB) - Mark CrawlSchedulePage as deprecated (removed from menu) - Add deprecation comments to legacy schedule methods in api.ts - Add migration comments to workers.ts explaining consolidation Key changes: - Schedule management now at /admin/tasks instead of /admin/schedule - task_schedules uses interval_hours (simpler than base_interval_minutes + jitter) - All schedule routes placed before /:id to avoid Express route conflicts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-12 01:15:21 -07:00
parent a077f81c65
commit 6490df9faf
6 changed files with 1124 additions and 22 deletions
--- a/backend/src/routes/tasks.ts
+++ b/backend/src/routes/tasks.ts
@@ -3,6 +3,24 @@
 *
 * Endpoints for managing worker tasks, viewing capacity metrics,
 * and generating batch tasks.
+ *
+ * SCHEDULE MANAGEMENT (added 2025-12-12):
+ * This file now contains the canonical schedule management endpoints.
+ * The job_schedules table has been deprecated and all schedule management
+ * is now consolidated into task_schedules:
+ *
+ * Schedule endpoints:
+ *   GET    /api/tasks/schedules           - List all schedules
+ *   POST   /api/tasks/schedules           - Create new schedule
+ *   GET    /api/tasks/schedules/:id       - Get schedule by ID
+ *   PUT    /api/tasks/schedules/:id       - Update schedule
+ *   DELETE /api/tasks/schedules/:id       - Delete schedule
+ *   DELETE /api/tasks/schedules           - Bulk delete schedules
+ *   POST   /api/tasks/schedules/:id/run-now - Trigger schedule immediately
+ *   POST   /api/tasks/schedules/:id/toggle  - Toggle schedule enabled/disabled
+ *
+ * Note: Schedule routes are defined BEFORE /:id to avoid route conflicts
+ * (Express matches routes in order, and "schedules" would match /:id otherwise)
 */

 import { Router, Request, Response } from 'express';
@@ -131,6 +149,366 @@ router.get('/capacity/:role', async (req: Request, res: Response) => {
  }
 });

+// ============================================================
+// SCHEDULE MANAGEMENT ROUTES
+// (Must be before /:id to avoid route conflicts)
+// ============================================================
+
+/**
+ * GET /api/tasks/schedules
+ * List all task schedules
+ */
+router.get('/schedules', async (req: Request, res: Response) => {
+  try {
+    const enabledOnly = req.query.enabled === 'true';
+
+    let query = `
+      SELECT id, name, role, description, enabled, interval_hours,
+             priority, state_code, platform, last_run_at, next_run_at,
+             last_task_count, last_error, created_at, updated_at
+      FROM task_schedules
+    `;
+
+    if (enabledOnly) {
+      query += ` WHERE enabled = true`;
+    }
+
+    query += ` ORDER BY name`;
+
+    const result = await pool.query(query);
+    res.json({ schedules: result.rows });
+  } catch (error: unknown) {
+    console.error('Error listing schedules:', error);
+    res.status(500).json({ error: 'Failed to list schedules' });
+  }
+});
+
+/**
+ * DELETE /api/tasks/schedules
+ * Bulk delete schedules
+ *
+ * Body:
+ * - ids: number[] (required) - array of schedule IDs to delete
+ * - all: boolean (optional) - if true, delete all schedules (ids ignored)
+ */
+router.delete('/schedules', async (req: Request, res: Response) => {
+  try {
+    const { ids, all } = req.body;
+
+    let result;
+
+    if (all === true) {
+      // Delete all schedules
+      result = await pool.query(`
+        DELETE FROM task_schedules RETURNING id, name
+      `);
+    } else if (Array.isArray(ids) && ids.length > 0) {
+      // Delete specific schedules by IDs
+      result = await pool.query(`
+        DELETE FROM task_schedules WHERE id = ANY($1) RETURNING id, name
+      `, [ids]);
+    } else {
+      return res.status(400).json({
+        error: 'Either provide ids array or set all=true',
+      });
+    }
+
+    res.json({
+      success: true,
+      deleted_count: result.rowCount,
+      deleted: result.rows,
+      message: `Deleted ${result.rowCount} schedule(s)`,
+    });
+  } catch (error: unknown) {
+    console.error('Error bulk deleting schedules:', error);
+    res.status(500).json({ error: 'Failed to delete schedules' });
+  }
+});
+
+/**
+ * POST /api/tasks/schedules
+ * Create a new schedule
+ *
+ * Body:
+ * - name: string (required, unique)
+ * - role: TaskRole (required)
+ * - description: string (optional)
+ * - enabled: boolean (default true)
+ * - interval_hours: number (required)
+ * - priority: number (default 0)
+ * - state_code: string (optional)
+ * - platform: string (optional)
+ */
+router.post('/schedules', async (req: Request, res: Response) => {
+  try {
+    const {
+      name,
+      role,
+      description,
+      enabled = true,
+      interval_hours,
+      priority = 0,
+      state_code,
+      platform,
+    } = req.body;
+
+    if (!name || !role || !interval_hours) {
+      return res.status(400).json({
+        error: 'name, role, and interval_hours are required',
+      });
+    }
+
+    // Calculate next_run_at based on interval
+    const nextRunAt = new Date(Date.now() + interval_hours * 60 * 60 * 1000);
+
+    const result = await pool.query(`
+      INSERT INTO task_schedules
+        (name, role, description, enabled, interval_hours, priority, state_code, platform, next_run_at)
+      VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9)
+      RETURNING id, name, role, description, enabled, interval_hours,
+                priority, state_code, platform, last_run_at, next_run_at,
+                last_task_count, last_error, created_at, updated_at
+    `, [name, role, description, enabled, interval_hours, priority, state_code, platform, nextRunAt]);
+
+    res.status(201).json(result.rows[0]);
+  } catch (error: any) {
+    if (error.code === '23505') {
+      // Unique constraint violation
+      return res.status(409).json({ error: 'A schedule with this name already exists' });
+    }
+    console.error('Error creating schedule:', error);
+    res.status(500).json({ error: 'Failed to create schedule' });
+  }
+});
+
+/**
+ * GET /api/tasks/schedules/:id
+ * Get a specific schedule by ID
+ */
+router.get('/schedules/:id', async (req: Request, res: Response) => {
+  try {
+    const scheduleId = parseInt(req.params.id, 10);
+
+    const result = await pool.query(`
+      SELECT id, name, role, description, enabled, interval_hours,
+             priority, state_code, platform, last_run_at, next_run_at,
+             last_task_count, last_error, created_at, updated_at
+      FROM task_schedules
+      WHERE id = $1
+    `, [scheduleId]);
+
+    if (result.rows.length === 0) {
+      return res.status(404).json({ error: 'Schedule not found' });
+    }
+
+    res.json(result.rows[0]);
+  } catch (error: unknown) {
+    console.error('Error getting schedule:', error);
+    res.status(500).json({ error: 'Failed to get schedule' });
+  }
+});
+
+/**
+ * PUT /api/tasks/schedules/:id
+ * Update an existing schedule
+ */
+router.put('/schedules/:id', async (req: Request, res: Response) => {
+  try {
+    const scheduleId = parseInt(req.params.id, 10);
+    const {
+      name,
+      role,
+      description,
+      enabled,
+      interval_hours,
+      priority,
+      state_code,
+      platform,
+    } = req.body;
+
+    // Build dynamic update query
+    const updates: string[] = [];
+    const values: any[] = [];
+    let paramIndex = 1;
+
+    if (name !== undefined) {
+      updates.push(`name = $${paramIndex++}`);
+      values.push(name);
+    }
+    if (role !== undefined) {
+      updates.push(`role = $${paramIndex++}`);
+      values.push(role);
+    }
+    if (description !== undefined) {
+      updates.push(`description = $${paramIndex++}`);
+      values.push(description);
+    }
+    if (enabled !== undefined) {
+      updates.push(`enabled = $${paramIndex++}`);
+      values.push(enabled);
+    }
+    if (interval_hours !== undefined) {
+      updates.push(`interval_hours = $${paramIndex++}`);
+      values.push(interval_hours);
+
+      // Recalculate next_run_at if interval changed
+      const nextRunAt = new Date(Date.now() + interval_hours * 60 * 60 * 1000);
+      updates.push(`next_run_at = $${paramIndex++}`);
+      values.push(nextRunAt);
+    }
+    if (priority !== undefined) {
+      updates.push(`priority = $${paramIndex++}`);
+      values.push(priority);
+    }
+    if (state_code !== undefined) {
+      updates.push(`state_code = $${paramIndex++}`);
+      values.push(state_code || null);
+    }
+    if (platform !== undefined) {
+      updates.push(`platform = $${paramIndex++}`);
+      values.push(platform || null);
+    }
+
+    if (updates.length === 0) {
+      return res.status(400).json({ error: 'No fields to update' });
+    }
+
+    updates.push('updated_at = NOW()');
+    values.push(scheduleId);
+
+    const result = await pool.query(`
+      UPDATE task_schedules
+      SET ${updates.join(', ')}
+      WHERE id = $${paramIndex}
+      RETURNING id, name, role, description, enabled, interval_hours,
+                priority, state_code, platform, last_run_at, next_run_at,
+                last_task_count, last_error, created_at, updated_at
+    `, values);
+
+    if (result.rows.length === 0) {
+      return res.status(404).json({ error: 'Schedule not found' });
+    }
+
+    res.json(result.rows[0]);
+  } catch (error: any) {
+    if (error.code === '23505') {
+      return res.status(409).json({ error: 'A schedule with this name already exists' });
+    }
+    console.error('Error updating schedule:', error);
+    res.status(500).json({ error: 'Failed to update schedule' });
+  }
+});
+
+/**
+ * DELETE /api/tasks/schedules/:id
+ * Delete a schedule
+ */
+router.delete('/schedules/:id', async (req: Request, res: Response) => {
+  try {
+    const scheduleId = parseInt(req.params.id, 10);
+
+    const result = await pool.query(`
+      DELETE FROM task_schedules WHERE id = $1 RETURNING id, name
+    `, [scheduleId]);
+
+    if (result.rows.length === 0) {
+      return res.status(404).json({ error: 'Schedule not found' });
+    }
+
+    res.json({
+      success: true,
+      message: `Schedule "${result.rows[0].name}" deleted`,
+    });
+  } catch (error: unknown) {
+    console.error('Error deleting schedule:', error);
+    res.status(500).json({ error: 'Failed to delete schedule' });
+  }
+});
+
+/**
+ * POST /api/tasks/schedules/:id/run-now
+ * Manually trigger a scheduled task to run immediately
+ */
+router.post('/schedules/:id/run-now', async (req: Request, res: Response) => {
+  try {
+    const scheduleId = parseInt(req.params.id, 10);
+
+    // Get the schedule
+    const scheduleResult = await pool.query(`
+      SELECT id, name, role, state_code, platform, priority
+      FROM task_schedules WHERE id = $1
+    `, [scheduleId]);
+
+    if (scheduleResult.rows.length === 0) {
+      return res.status(404).json({ error: 'Schedule not found' });
+    }
+
+    const schedule = scheduleResult.rows[0];
+
+    // Create a task based on the schedule
+    const task = await taskService.createTask({
+      role: schedule.role,
+      platform: schedule.platform,
+      priority: schedule.priority + 10, // Boost priority for manual runs
+    });
+
+    // Update last_run_at on the schedule
+    await pool.query(`
+      UPDATE task_schedules
+      SET last_run_at = NOW(),
+          next_run_at = NOW() + (interval_hours || ' hours')::interval,
+          updated_at = NOW()
+      WHERE id = $1
+    `, [scheduleId]);
+
+    res.json({
+      success: true,
+      message: `Schedule "${schedule.name}" triggered`,
+      task,
+    });
+  } catch (error: unknown) {
+    console.error('Error running schedule:', error);
+    res.status(500).json({ error: 'Failed to run schedule' });
+  }
+});
+
+/**
+ * POST /api/tasks/schedules/:id/toggle
+ * Toggle a schedule's enabled status
+ */
+router.post('/schedules/:id/toggle', async (req: Request, res: Response) => {
+  try {
+    const scheduleId = parseInt(req.params.id, 10);
+
+    const result = await pool.query(`
+      UPDATE task_schedules
+      SET enabled = NOT enabled,
+          updated_at = NOW()
+      WHERE id = $1
+      RETURNING id, name, enabled
+    `, [scheduleId]);
+
+    if (result.rows.length === 0) {
+      return res.status(404).json({ error: 'Schedule not found' });
+    }
+
+    res.json({
+      success: true,
+      schedule: result.rows[0],
+      message: result.rows[0].enabled
+        ? `Schedule "${result.rows[0].name}" enabled`
+        : `Schedule "${result.rows[0].name}" disabled`,
+    });
+  } catch (error: unknown) {
+    console.error('Error toggling schedule:', error);
+    res.status(500).json({ error: 'Failed to toggle schedule' });
+  }
+});
+
+// ============================================================
+// TASK-SPECIFIC ROUTES (with :id parameter)
+// ============================================================
+
 /**
 * GET /api/tasks/:id
 * Get a specific task by ID